Dka34/enhanced locations #555
Conversation
|
[diff-counting] Significant lines: 1001. This diff might be too big! Developer leads are invited to review the code. |
There was a problem hiding this comment.
Hey Desmond, I checked out this PR and I really like how clean the locations modal looks now!
In terms of functionality, since searching acronyms like RPCC doesn't return anything, I think either editing the search functionality to also search the description or just adding acronyms into the title itself could make this more user friendly (ie. Robert Purcell Community Center (RPCC) ), but overall this looks really good to me!
|
I think it looks good so far, I like the integration of the google mapsAPI. I agree with Selena that for consistency we should switch to keeping the CSS in a separate folder, incase we decide to change from vanilla CSS to another frontend framework like MUI then it'll be easier. Good job Desmond. |
Summary
This pull request is a large PR aimed at enhancing the locations page to allow for a more user friendly experience
Feature support
A user should have access to a map bounded on Ithaca
The user can interact with the map and add new locations to the map
The user should also have access to a list which allows them to have a comprehensive view of the locations
Google Maps API integration - maps, markers, places integration
Markers - Adding Advanced customizable markers which can show on the google maps and users can interact with it
Marker Clustering - Should be able to cluster markers that are condensed together
Maps Interactions - Users can pan, zoom , drag , etc on the map. They can also click on the map.
Maps Pop up - Users can view more details on a location, this should include more detailed information which would be added later
Maps bounds - Map should be bounded to Ithaca area.
Locations List - Comprehensive locations list showing all added locations and existing locations
Search and Filtering - Ability to search and filter through locations list. Also affects main map
Locations Modal - Using Material UI dialog box component to create a modal for submission of adding a new location
Editing Location - User should be able to edit an existing location
Layout Design - Proper CSS styling
Backend Support for the new Locations
Test Plan
manually tested on Arc browser and Chrome.
General Map Interactions + Adding of Locations with updated Modal
Screen.Recording.2024-11-16.at.3.43.35.AM.mp4
Map Pop ups , Locations List Pop ups + Editing of locations
Screen.Recording.2024-11-17.at.3.44.56.AM.mov
Notes
The current locations modal follows the idea from the Figma where there is a two panel system containing maps and locations list to enhance the user experience.
The data flow goes as follows : Locations data is handled in the Locations.tsx file and LocationsContent.tsx is the main file containing the maps display and list display. All business logic for locations is done in the parent component.
Breaking Changes
No breaking changes currentlyNot a breaking change but a couple unintuitive features